Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor: Change packages in the common module #1466

Merged
merged 1 commit into from
Jan 7, 2021
Merged

refactor: Change packages in the common module #1466

merged 1 commit into from
Jan 7, 2021

Conversation

pawelpasterz
Copy link
Contributor

Fixes #1458

Test Plan

How do we know the code works?

No changes in the logic. Unit tests should be enough

@pawelpasterz pawelpasterz self-assigned this Jan 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@pawelpasterz pawelpasterz enabled auto-merge (rebase) January 6, 2021 07:47
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2021 •
edited
Loading

Timestamp: 2021-01-06 11:50:59
Buildscan url for ubuntu-workflow run 465994091
https://gradle.com/s/th3tyllaio7fg

Sloox
Sloox approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just rename changes :)

@bootstraponline bootstraponline force-pushed the 1458-fix-doted-directory branch from ec73b30 to 62c4fbd Compare January 6, 2021 11:46
@pawelpasterz pawelpasterz merged commit 563fd3a into master Jan 7, 2021
@pawelpasterz pawelpasterz deleted the 1458-fix-doted-directory branch January 7, 2021 06:16
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2021
@zuziaka zuziaka added this to the Sprint -1 milestone Jan 19, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@Sloox Sloox Sloox approved these changes

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

Assignees

@pawelpasterz pawelpasterz

Labels
Snake 🐍 Tech Debt
Projects
None yet
Milestone
Sprint -1
Development

Successfully merging this pull request may close these issues.

Invalid directory name with dot character
4 participants
@pawelpasterz @Sloox @piotradamczyk5 @zuziaka