Add flags to disable video recording and performance metrics

Flank/src/main/java/com/walmart/otto/configurator/ConfigReader.java

@@ -140,6 +140,14 @@ private void setProperty(String property, String value) throws IllegalArgumentEx
         configurator.setDisableAutoGoogleLogin(Boolean.parseBoolean(value));
         break;
 
+      case "record-video":
+        configurator.setRecordVideo(Boolean.parseBoolean(value));
+        break;
+
+      case "record-performance-metrics":
+        configurator.setRecordPerformanceMetrics(Boolean.parseBoolean(value));
+        break;
+
       default:
         break;
     }

Flank/src/main/java/com/walmart/otto/configurator/Configurator.java

@@ -8,6 +8,7 @@
 import java.util.List;
 
 public class Configurator {
+
   private List<String> deviceIds = new ArrayList<>(Collections.singletonList("Nexus6P"));
   private List<String> locales = new ArrayList<>(Collections.singletonList("en"));
   private List<String> orientations = new ArrayList<>(Collections.singletonList("portrait"));
@@ -25,6 +26,8 @@ public class Configurator {
   private boolean debug = false;
   private boolean fetchBucket = false;
   private boolean disableAutoGoogleLogin = false;
+  private boolean recordVideo = true;
+  private boolean recordPerformanceMetrics = true;
   private int numShards = -1;
   private int shardIndex = -1;
   private int shardTimeout = 5;
@@ -201,6 +204,22 @@ public void setDisableAutoGoogleLogin(boolean disableAutoGoogleLogin) {
     this.disableAutoGoogleLogin = disableAutoGoogleLogin;
   }
 
+  public boolean recordVideo() {
+    return recordVideo;
+  }
+
+  public void setRecordVideo(boolean recordVideo) {
+    this.recordVideo = recordVideo;
+  }
+
+  public boolean recordPerformanceMetrics() {
+    return recordPerformanceMetrics;
+  }
+
+  public void setRecordPerformanceMetrics(boolean recordPerformanceMetrics) {
+    this.recordPerformanceMetrics = recordPerformanceMetrics;
+  }
+
   private void setupDevices() {
     devices = new ArrayList<>();
     for (String locale : locales) {

Flank/src/main/java/com/walmart/otto/tools/GcloudTool.java

@@ -14,6 +14,7 @@
 import java.util.stream.Collectors;
 
 public class GcloudTool extends Tool {
+
   private boolean printTests = true;
   private boolean testFailed = false;
   private int latestExecutionTime;
@@ -37,6 +38,8 @@ public void runGcloud(String testCase, String bucket, int shardIndex)
           "instrumentation",
           orchestratorFlag(),
           autoGoogleLoginFlag(),
+          recordVideoFlag(),
+          performanceMetricsFlag(),
           "--app",
           bucket + getSimpleName(getAppAPK()),
           "--test",
@@ -88,6 +91,20 @@ private String autoGoogleLoginFlag() {
     return "";
   }
 
+  private String recordVideoFlag() {
+    if (!getConfigurator().recordVideo()) {
+      return "--no-record-video";
+    }
+    return "";
+  }
+
+  private String performanceMetricsFlag() {
+    if (!getConfigurator().recordPerformanceMetrics()) {
+      return "--no-performance-metrics";
+    }
+    return "";
+  }
+
   private String betaConfiguration() {
     if (getConfigurator().isUseGCloudBeta()) {
       return "beta";

README.md

@@ -66,6 +66,8 @@ gsutil-path: The path to the gsutil binary
 gcloud-bucket: The Google Cloud Storage bucket to use. If not specified Flank will create one.
 use-gcloud-beta: If gcloud beta should be used
 disable-google-login: If the argument `--no-auto-google-login` should be passed to the gcloud command line.
+record-video: If the video of the instrumentation test should be recorded. True by default.
+record-performance-metrics: If the performance metrics should be recorded. True by default.
 
 aggregate-reports.enabled: Enable the experimental test aggregation feature. Requires fetch-bucket to be enabled. Disabled by default.
 aggregate-reports.xml: Generates and pushes to Google Cloud Storage an aggregated XML report

release_notes.md

@@ -8,3 +8,4 @@ Release notes for flank
 
 - [Add IntelliJ Idea Code Formatting settings for Java Flank - **sridoodla**](https://github.com/TestArmada/flank/pull/147)
 - [Add ability to disable google login - **runningcode**](https://github.com/TestArmada/flank/pull/146)
+- [Add the ability to disable video recording and performance metrics - **sridoodla**](https://github.com/TestArmada/flank/pull/149)