Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor: Refactor flank scripts #1533

Merged
merged 21 commits into from
Feb 3, 2021
Merged

refactor: Refactor flank scripts #1533

merged 21 commits into from
Feb 3, 2021

Conversation

adamfilipow92
Copy link
Contributor

@adamfilipow92 adamfilipow92 commented Jan 25, 2021 •
edited by jan-goral
Loading

Fixes #1541

Test Plan

How do we know the code works?

All tests pass, Flank scripts work like before

Checklist

  • CiCommand
  • ContributionCommand
  • DependenciesCommand
  • PullRequestCommand
  • IntegrationCommand
  • ReleaseCommand
  • ShellCommand
    • FirebaseCommand,
    • BuildExampleCommand,
    • BuildFtlCommand,
    • RunFtlLocalCommand,
    • UniversalFrameworkCommand,
    • OpsCommand,
    • UpdateBinariesCommand,
    • BuildFlankCommand,
    • InstallXcPrettyCommand,
    • SetupIosEnvCommand
  • TestArtifactsCommand
  • Utils
  • Tests

@adamfilipow92 adamfilipow92 self-assigned this Jan 25, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@adamfilipow92 adamfilipow92 changed the title refractor: Refractor flank scripts refactor: Refractor flank scripts Jan 25, 2021
@adamfilipow92 adamfilipow92 changed the title refactor: Refractor flank scripts refactor: Refactor flank scripts Jan 25, 2021
@piotradamczyk5 piotradamczyk5 force-pushed the 1356-refractor-flank-scripts branch 2 times, most recently from acb3ea5 to 75986e0 Compare January 27, 2021 16:58
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2021 •
edited
Loading

Timestamp: 2021-02-01 10:29:43
Buildscan url for ubuntu-workflow run 527384427

@piotradamczyk5 piotradamczyk5 marked this pull request as ready for review January 28, 2021 13:10
@bootstraponline bootstraponline force-pushed the 1356-refractor-flank-scripts branch from 9bc349d to 80d82e4 Compare January 28, 2021 15:51
@piotradamczyk5 piotradamczyk5 force-pushed the 1356-refractor-flank-scripts branch 2 times, most recently from 4526adb to 21f8d79 Compare January 29, 2021 13:25
@bootstraponline bootstraponline force-pushed the 1356-refractor-flank-scripts branch 3 times, most recently from 6485c4b to c006d5b Compare February 1, 2021 08:25
@bootstraponline bootstraponline force-pushed the 1356-refractor-flank-scripts branch from c006d5b to 03cd03c Compare February 1, 2021 10:24
@zuziaka
Copy link
Contributor

zuziaka commented Feb 2, 2021

This PR is implementation of a #1541

@zuziaka
Copy link
Contributor

zuziaka commented Feb 2, 2021

Comment for a future: Maybe we can this kind of PR's extract into smaller batches. For example this issue could be solved in 4 different PRs:

  1. Separate logical operations from CliKt commands.
  2. Group CliKt commands in cli package and fix the structure
  3. Group all domain code in ops package
  4. Separate utils and data

What do you think?

Nvm, I'm reviewing it 😃

@mergify mergify bot merged commit ae09391 into master Feb 3, 2021
@mergify mergify bot deleted the 1356-refractor-flank-scripts branch February 3, 2021 10:43
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@zuziaka zuziaka zuziaka approved these changes

@jan-goral jan-goral jan-goral approved these changes

Assignees

@jan-goral jan-goral

@adamfilipow92 adamfilipow92

@piotradamczyk5 piotradamczyk5

Labels
Refactor Tech Debt Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Organize flank scripts into separated layers
4 participants
@adamfilipow92 @zuziaka @jan-goral @piotradamczyk5