-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: Move shards json to result directory #1557
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
@flank-it |
Integration tests were triggered at 2021-02-02 17:32:29, you can track progress here |
Timestamp: 2021-02-03 16:31:31 |
@@ -151,5 +153,8 @@ val AndroidArgs.isSanityRobo | |||
val AndroidArgs.isGameLoop | |||
get() = if (type == null) false else (type == Type.GAMELOOP) | |||
|
|||
val AndroidArgs.shardsFilePath | |||
get() = Paths.get(localResultDir, resultsDir, ANDROID_SHARD_FILE).toAbsolutePath().toString() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if localResultsDir
is different than default, we should not add file to resultsDir
. We have similar logic in the whole app
Title does not follow the guidelines of Conventional Commits.
|
Fixes #1475
Test Plan
results-directory
is created*_shards.json
existsdisable-results-upload
not set, check shards file exists in gcloud bucketdisable-results-upload
setChecklist