Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Move shards json to result directory #1557

Merged
merged 7 commits into from
Feb 3, 2021

Conversation

adamfilipow92
Copy link
Contributor

@adamfilipow92 adamfilipow92 commented Feb 2, 2021

Fixes #1475

Test Plan

How do we know the code works?

  1. Run flank with android or ios test
  2. Wait until results-directory is created
  3. Open the results directory and check *_shards.json exists
  4. If disable-results-upload not set, check shards file exists in gcloud bucket
  5. Flank shouldn't upload shards file to gcs if disable-results-upload set

Checklist

@adamfilipow92 adamfilipow92 self-assigned this Feb 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@adamfilipow92 adamfilipow92 marked this pull request as ready for review February 2, 2021 17:31
@adamfilipow92
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2021

Integration tests were triggered at 2021-02-02 17:32:29, you can track progress here

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2021

Timestamp: 2021-02-03 16:31:31
Buildscan url for ubuntu-workflow run 534460928

@adamfilipow92 adamfilipow92 marked this pull request as ready for review February 3, 2021 14:35
@@ -151,5 +153,8 @@ val AndroidArgs.isSanityRobo
val AndroidArgs.isGameLoop
get() = if (type == null) false else (type == Type.GAMELOOP)

val AndroidArgs.shardsFilePath
get() = Paths.get(localResultDir, resultsDir, ANDROID_SHARD_FILE).toAbsolutePath().toString()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if localResultsDir is different than default, we should not add file to resultsDir. We have similar logic in the whole app

@mergify
Copy link

mergify bot commented Feb 3, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@adamfilipow92 adamfilipow92 changed the title bug: Move shards json to result directory fix: Move shards json to result directory Feb 3, 2021
@mergify mergify bot merged commit 38e09ed into master Feb 3, 2021
@mergify mergify bot deleted the 1475-move-shards-json-to-result-directory branch February 3, 2021 16:35
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move shards.json to results directory
3 participants