Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Increase heap size #1575

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Conversation

pawelpasterz
Copy link
Contributor

@pawelpasterz pawelpasterz commented Feb 8, 2021

Fixes #1577

Increase heap size for test task in test_runner module. This should mitigate OutOfMemory error during tests

Test Plan

How do we know the code works?

  1. Run ./gradlew clean flankFullRun -- should finish without any error
  2. We can rerun ubuntu-workflow a couple of times and each should end with success

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2021

Timestamp: 2021-02-09 14:01:37
Buildscan url for ubuntu-workflow run 549219635
https://gradle.com/s/xpstitwmytnya

@pawelpasterz pawelpasterz force-pushed the increase-heap-for-test_runner-tests branch from d195f2f to 7b4dbb6 Compare February 8, 2021 20:35
@@ -378,4 +378,8 @@ val resolveArtifacts by tasks.registering {
}
}

tasks.test { dependsOn(resolveArtifacts) }
tasks.test {
maxHeapSize = "3072m"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the issue because of ubuntu failing all the time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, here is the summary of my investigation #1577

@pawelpasterz pawelpasterz self-assigned this Feb 9, 2021
@pawelpasterz pawelpasterz marked this pull request as ready for review February 9, 2021 13:28
@piotradamczyk5 piotradamczyk5 self-requested a review February 9, 2021 14:38
@mergify mergify bot merged commit af3e37a into master Feb 9, 2021
@mergify mergify bot deleted the increase-heap-for-test_runner-tests branch February 9, 2021 14:38
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OutOfMemory: Java Heap Size error during tests
3 participants