Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: Move function to files which use them #1589

Merged
merged 4 commits into from
Feb 12, 2021

Conversation

piotradamczyk5
Copy link
Contributor

Fixes #1584

There is not change in logic. Just moving functions to files that use them

Test Plan

How do we know the code works?

All tests passed.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2021

Timestamp: 2021-02-12 16:31:05
Buildscan url for ubuntu-workflow run 561565505
https://gradle.com/s/3hn2y56ukgume

Copy link
Contributor

@jan-goral jan-goral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GradleCommand.kt -> utils
createLipoCommand -> UniversalFramework.kt
UpdateVersionsInFile.kt + other common stuff related to dependencies update -> utils or dedicated package
UpdateBinaries.kt -> ops.dependencies cause public top level functions should be exposed
CheckForSDKUpdateCommand.kt -> CheckForSDKUpdate.kt
getLastSDKUpdateRunDate -> CheckForSDKUpdate.kt
checkForOpenedUpdates -> CheckForSDKUpdate.kt
findReferenceNumber -> CopyGitHubProperties.kt
IntegrationContext.kt, ITResults, PrepareMessage.kt -> ops.integrationtests.processresult
retrieveKtlintResolveCommand -> private
ops.release.jfrog -> ops.jfrog
isNewVersionAvailable -> ResolveArtifacts.kt
ArtifactsArchive.kt, Constants.kt, Context, TestArtifactsRepo.kt -> ops.testartifacts.helper

@piotradamczyk5 piotradamczyk5 force-pushed the #1584_refactor_ops branch 2 times, most recently from 04589ca to dd86be5 Compare February 12, 2021 16:25
@piotradamczyk5 piotradamczyk5 marked this pull request as ready for review February 12, 2021 16:25
@piotradamczyk5 piotradamczyk5 enabled auto-merge (squash) February 12, 2021 16:38
@piotradamczyk5 piotradamczyk5 merged commit 65a00e8 into master Feb 12, 2021
@piotradamczyk5 piotradamczyk5 deleted the #1584_refactor_ops branch February 12, 2021 16:40
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants