-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
refactor: Move function to files which use them #1589
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Timestamp: 2021-02-12 16:31:05 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GradleCommand.kt
-> utils
createLipoCommand
-> UniversalFramework.kt
UpdateVersionsInFile.kt
+ other common stuff related to dependencies update -> utils
or dedicated package
UpdateBinaries.kt
-> ops.dependencies
cause public top level functions should be exposed
CheckForSDKUpdateCommand.kt
-> CheckForSDKUpdate.kt
getLastSDKUpdateRunDate
-> CheckForSDKUpdate.kt
checkForOpenedUpdates
-> CheckForSDKUpdate.kt
findReferenceNumber
-> CopyGitHubProperties.kt
IntegrationContext.kt
, ITResults
, PrepareMessage.kt
-> ops.integrationtests.processresult
retrieveKtlintResolveCommand
-> private
ops.release.jfrog
-> ops.jfrog
isNewVersionAvailable
-> ResolveArtifacts.kt
ArtifactsArchive.kt
, Constants.kt
, Context
, TestArtifactsRepo.kt
-> ops.testartifacts.helper
04589ca
to
dd86be5
Compare
dd86be5
to
5b0c66b
Compare
Fixes #1584
There is not change in logic. Just moving functions to files that use them
Test Plan
All tests passed.