test: Added app with many tests #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotradamczyk5
requested review from
bootstraponline,
Sloox,
zuziaka,
pawelpasterz,
jan-goral and
adamfilipow92
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
Timestamp: 2021-03-24 08:34:02 |
jan-goral
approved these changes
Mar 23, 2021
| @@ -23,4 +23,8 @@ function cucumber_sample_app() { | |||
| $DIR/../../flank-scripts/bash/flankScripts assemble android app --copy --generate --artifacts=buildCucumberSampleApp | |||
| } | |||
|
|
|||
| function many_tests_apk() { | |||
There was a problem hiding this comment.
Do we have any good reasons for supporting shell scripts, now? Wasn't a flank-scripts a replacement for the shell?
This is not a change request, I am just thinking about adding an issue for removing any ops.sh
There was a problem hiding this comment.
ops.sh just run flankScripts with the proper command it was added for backward compatibility, but sure we could remove it
There was a problem hiding this comment.
+1 to not having shell scripts if possible
bootstraponline
force-pushed
the
1649_added_test_app_with_multiple_tests
branch
from
d8a52b7 to
c064e20
Compare
jan-goral
reviewed
Mar 23, 2021
flank-scripts/src/main/kotlin/flank/scripts/ops/assemble/android/BuildManyTestsApk.kt
Outdated
Show resolved
Hide resolved
bootstraponline
force-pushed
the
1649_added_test_app_with_multiple_tests
branch
from
7f5c537 to
d47dbc5
Compare
Sloox
approved these changes
Mar 24, 2021
|
|
||
| @Test | ||
| fun test59() { | ||
| assertEquals(true, "true".toBoolean()) |
There was a problem hiding this comment.
Welldone what a pain in the ....
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1650
Test Plan
Tests app with many tests could be built.
It is needed for example to add IT in #1650