Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: Follow up refactor fix #1732

Merged
merged 1 commit into from
Mar 24, 2021
Merged

fix: Follow up refactor fix #1732

merged 1 commit into from
Mar 24, 2021

Conversation

pawelpasterz
Copy link
Contributor

@pawelpasterz pawelpasterz commented Mar 24, 2021 •
edited
Loading

Fixes #1731

This is follow up fix for #1724

Test Plan

How do we know the code works?

  1. run./gradlew flankFullRun -- no errors
  2. IT passes

@pawelpasterz pawelpasterz self-assigned this Mar 24, 2021
@pawelpasterz pawelpasterz changed the title Follow up refactor fix fix: Follow up refactor fix Mar 24, 2021
@github-actions
Copy link
Contributor

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@pawelpasterz
Copy link
Contributor Author

@flank-it

@pawelpasterz pawelpasterz enabled auto-merge (squash) March 24, 2021 05:33
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2021 •
edited
Loading

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan: https://gradle.com/s/lqyuxbsycwmuk
Linux status failure - Build scan: https://gradle.com/s/kfufhl5toxugw
Workflow run https://github.com/Flank/flank/actions/runs/681985215

@github-actions github-actions bot added the IT_Failed Issue created by GH bot when IT fails on master label Mar 24, 2021
@github-actions
Copy link
Contributor

Timestamp: 2021-03-24 05:39:09
Buildscan url for ubuntu-workflow run 681984675
https://gradle.com/s/6dq2yyfsdgtf2

@piotradamczyk5 piotradamczyk5 self-requested a review March 24, 2021 05:48
@pawelpasterz
Copy link
Contributor Author

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan: https://gradle.com/s/lqyuxbsycwmuk
Linux status failure - Build scan: https://gradle.com/s/kfufhl5toxugw
Workflow run https://github.com/Flank/flank/actions/runs/681985215

Failing due to quota limit -- to rerun later

@pawelpasterz pawelpasterz merged commit 9483cc0 into master Mar 24, 2021
@pawelpasterz pawelpasterz deleted the follow-up-refactor-fix branch March 24, 2021 08:26
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@Sloox Sloox Sloox approved these changes

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

Assignees

@pawelpasterz pawelpasterz

Labels
Bug IT_Failed Issue created by GH bot when IT fails on master Snake 🐍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Full Suite integration tests failed on master
3 participants
@pawelpasterz @Sloox @piotradamczyk5