Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: Windows IOS integration tests #1739

Merged
merged 11 commits into from
Apr 1, 2021
Merged

feat: Windows IOS integration tests #1739

merged 11 commits into from
Apr 1, 2021

Conversation

Sloox
Copy link
Contributor

@Sloox Sloox commented Mar 26, 2021 •
edited
Loading

Fixes #1686

Test Plan

How do we know the code works?

IT tests will work

Checklist

  • Integration tests updated

@Sloox Sloox self-assigned this Mar 26, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2021 •
edited
Loading

Timestamp: 2021-04-01 08:56:06
Buildscan url for ubuntu-workflow run 707927671
https://gradle.com/s/fl7cta6wmi5c4

@Flank Flank deleted a comment from github-actions bot Mar 26, 2021
@piotradamczyk5 piotradamczyk5 mentioned this pull request Mar 29, 2021
Closed
@Flank Flank deleted a comment from github-actions bot Mar 29, 2021
@Flank Flank deleted a comment from github-actions bot Mar 29, 2021
@Sloox Sloox marked this pull request as ready for review March 31, 2021 09:01
@Flank Flank deleted a comment from github-actions bot Mar 31, 2021
@piotradamczyk5
Copy link
Contributor

@flank-it

@piotradamczyk5 piotradamczyk5 self-requested a review March 31, 2021 13:31
piotradamczyk5
piotradamczyk5 previously requested changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IT failed even for MacOS https://github.com/Flank/flank/actions/runs/705041576

quota...

@adamfilipow92 adamfilipow92 self-assigned this Mar 31, 2021
@Flank Flank deleted a comment from github-actions bot Apr 1, 2021
@Sloox Sloox requested a review from piotradamczyk5 April 1, 2021 07:54
@Sloox
Copy link
Contributor Author

Sloox commented Apr 1, 2021

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2021 •
edited
Loading

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/x6npoqwmdj3v6
Linux Build scan: https://gradle.com/s/o66rxijhjn2z2
Workflow run https://github.com/Flank/flank/actions/runs/707799199

@mergify mergify bot merged commit c7f029f into master Apr 1, 2021
@mergify mergify bot deleted the #1686-IT-tests branch April 1, 2021 15:49
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@zuziaka zuziaka Awaiting requested review from zuziaka

@jan-goral jan-goral Awaiting requested review from jan-goral

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

Assignees

@Sloox Sloox

@adamfilipow92 adamfilipow92

Labels
Feature P2 Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS IT Windows: Fix Windows Paths & Linking issues
4 participants
@Sloox @piotradamczyk5 @pawelpasterz @adamfilipow92