Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: Add 3dmark instrumented test #1783

Merged
merged 10 commits into from
Apr 15, 2021
Merged

test: Add 3dmark instrumented test #1783

merged 10 commits into from
Apr 15, 2021

Conversation

jan-goral
Copy link
Contributor

@jan-goral jan-goral commented Apr 7, 2021

Fixes #1771

The instrumented test based on ui-automator should run a benchmark on the tested device.
The benchmark must be installed on the tested device.

Goal

Running the benchmark on FTL device and obtaining the benchmark results.

Config

https://github.com/Flank/flank/blob/1771_ftl_benchmarks/test_runner/src/test/kotlin/ftl/fixtures/benchmark.yml

Details

  • The benchmark apk file is specified using additional-apks option
  • The 3dmark benchmark results will be pulled from device dir /sdcard/Android/data/com.futuremark.dmandroid.application/files/3DMarkAndroid/

Test Plan

How do we know the code works?

copy

  • Geekbench 5_v5.3.2.apk
  • 3dmarkandroid-v2-1-4726.apk

to test_artifacts/1771_ftl_benchmarks/apk/benchmark/

. .env
buildFlankScripts
flankScripts assemble app --artifact benchmark
cd test_runner
flank android run -c="./src/test/kotlin/ftl/fixtures/benchmark/*.yml"

Devices

  • Pixel 5e (physical) - API 30
  • NexusLowRes (virtual) - API 30
  • NexusLowResEmulator (emulator) - API 30

Results

3dmarkandroid-v2-1-4726.apk

Geekbench - all passed 836e622 firebase

  • Pixel 5e (physical) - API 30 - video
  • NexusLowRes (virtual) - API 30 - video
  • NexusLowResEmulator (emulator) - API 30 - video

PassMark

  • NexusLowRes (virtual) - API 30
  • NexusLowResEmulator (emulator) - API 30 - starting but failing during the benchmark - video b239766

Checklist

  • Documented

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@jan-goral
Copy link
Contributor Author

jan-goral commented Apr 7, 2021

Seems it requires a fix of ui-automator script, locally it works fine, on the emulator with the same resolution.
https://gist.github.com/jan-gogo/551af038e180113b10dcd9d4ade7a82c

@jan-goral jan-goral changed the title Add 3dmark instrumented test test: Add 3dmark instrumented test Apr 7, 2021
@jan-goral
Copy link
Contributor Author

redfin-30-en-portrait 3dmark

2021-04-08_09-26-05_redfin-30-en-portrait_3dmark

NexusLowRes-30-en-portrait geekbench

2021-04-08_11-35-15_NexusLowRes-30-en-portrait_geekbench

NexusLowResEmulator-30-en-portrait geekbench

2021-04-08_11-35-15_NexusLowResEmulator-30-en-portrait_geekbench

redfin-30-en-portrait geekbench

2021-04-08_11-35-15_redfin-30-en-portrait_geekbench

@jan-goral jan-goral marked this pull request as ready for review April 14, 2021 16:39
@github-actions
Copy link
Contributor

Timestamp: 2021-04-14 20:52:24
Buildscan url for ubuntu-workflow run 749725221
https://gradle.com/s/blgxzn7qbe2o4

Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comments.

import flank.scripts.utils.runCommand
import java.nio.file.Paths

// TODO Design common abstraction for building apks and coping artifacts, add java doc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth making a ticket so its not forgotten about?

# For more details, see
# http://developer.android.com/guide/developing/tools/proguard.html

# If your project uses WebView with JS, uncomment the following
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can technically remove this file.
Everyline is commented out :)

@mergify mergify bot merged commit 6dbf8be into master Apr 15, 2021
@mergify mergify bot deleted the 1771_ftl_benchmarks branch April 15, 2021 07:59
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2021
@Sloox
Copy link
Contributor

Sloox commented Apr 15, 2021

@jan-gogo is it worth to add the pictures to documentation as it will be lost in this PR?

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run benchamarks on FTL devices
3 participants