Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor: Refactor data scratch-authorization #1809

Merged
merged 2 commits into from
Apr 15, 2021
Merged

refactor: Refactor data scratch-authorization #1809

merged 2 commits into from
Apr 15, 2021

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Apr 14, 2021 •
edited
Loading

Fixes #1740

Test Plan

How do we know the code works?

Checklist

  • Unit tested

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@piotradamczyk5 piotradamczyk5 force-pushed the 1740-refactor_data_scratch_authorization branch 2 times, most recently from 2da812b to c101dc5 Compare April 14, 2021 17:07
@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2021 •
edited
Loading

Timestamp: 2021-04-15 13:29:24
Buildscan url for ubuntu-workflow run 752167389
https://gradle.com/s/yqin4rekqhmj2

@piotradamczyk5 piotradamczyk5 force-pushed the 1740-refactor_data_scratch_authorization branch from c101dc5 to 922ad06 Compare April 14, 2021 17:28
Sloox
Sloox approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

test_runner/src/main/kotlin/ftl/adapter/GoogleUserAuthorizationRequest.kt
import ftl.data.UserAuthorization

object GoogleUserAuthorizationRequest :
UserAuthorization.Request,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm ktlint formatting for this is stupid. I will look into it in some time.

@bootstraponline bootstraponline force-pushed the 1740-refactor_data_scratch_authorization branch from 922ad06 to fba8b4c Compare April 15, 2021 07:59
@piotradamczyk5 piotradamczyk5 merged commit 458a12e into master Apr 15, 2021
@piotradamczyk5 piotradamczyk5 deleted the 1740-refactor_data_scratch_authorization branch April 15, 2021 13:34
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@Sloox Sloox Sloox approved these changes

@jan-goral jan-goral jan-goral approved these changes

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@zuziaka zuziaka Awaiting requested review from zuziaka

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

Assignees

@piotradamczyk5 piotradamczyk5

Labels
Refactor Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data scratch - authorization
4 participants
@piotradamczyk5 @Sloox @jan-goral @adamfilipow92