Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor: Refactor data scratch-orientation #1820

Merged
merged 1 commit into from
Apr 20, 2021
Merged

refactor: Refactor data scratch-orientation #1820

merged 1 commit into from
Apr 20, 2021

Conversation

piotradamczyk5
Copy link
Contributor

Fixes #1749

Test Plan

How do we know the code works?

  • Code is refactored according to the description in Data scratch - orientations #1749
  • commandsflank android screen-orientations list and flank ios screen-orientations list run without any problems

Checklist

  • Unit tested

@piotradamczyk5 piotradamczyk5 marked this pull request as draft April 19, 2021 18:12
@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@piotradamczyk5 piotradamczyk5 force-pushed the 1749_refactor_orientation branch from dc9d085 to 20d72c0 Compare April 20, 2021 13:14
@piotradamczyk5 piotradamczyk5 marked this pull request as ready for review April 20, 2021 13:17
@piotradamczyk5 piotradamczyk5 force-pushed the 1749_refactor_orientation branch from 20d72c0 to 0e1f478 Compare April 20, 2021 13:19
@piotradamczyk5 piotradamczyk5 enabled auto-merge (squash) April 20, 2021 13:26
@github-actions
Copy link
Contributor

Timestamp: 2021-04-20 13:26:29
Buildscan url for ubuntu-workflow run 767260216
https://gradle.com/s/cuc6ytj6nv7ei

adamfilipow92
adamfilipow92 approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Works as expected
  • Code looks good

@piotradamczyk5 piotradamczyk5 merged commit e4c9e25 into master Apr 20, 2021
@piotradamczyk5 piotradamczyk5 deleted the 1749_refactor_orientation branch April 20, 2021 14:46
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@Sloox Sloox Sloox approved these changes

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@zuziaka zuziaka Awaiting requested review from zuziaka

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

@jan-goral jan-goral Awaiting requested review from jan-goral

Assignees

@piotradamczyk5 piotradamczyk5

Labels
Refactor Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data scratch - orientations
3 participants
@piotradamczyk5 @Sloox @adamfilipow92