refactor: list android locales #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Sloox
requested review from
jan-goral,
piotradamczyk5,
adamfilipow92,
zuziaka,
bootstraponline and
pawelpasterz
|
Timestamp: 2021-05-04 16:06:53 |
bootstraponline
force-pushed
the
#1854-list-android-locales
branch
from
d26353b to
4cd27c8
Compare
bootstraponline
force-pushed
the
#1854-list-android-locales
branch
from
4cd27c8 to
701f3fe
Compare
| override val out = outputLogger { | ||
| @Suppress("UNCHECKED_CAST") | ||
| when (this) { | ||
| is List<*> -> (this as List<Locale>).toCliTable() |
There was a problem hiding this comment.
IMO toCliTable should be moved to presentation layer
There was a problem hiding this comment.
Isn't it already there?
There was a problem hiding this comment.
@piotradamczyk5 it will be auto moved when another ticket is merged
piotradamczyk5
approved these changes
May 5, 2021
pawelpasterz
approved these changes
May 5, 2021
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1854
Test Plan
Checklist