fix: Several minor issues in corellium scope #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-goral
requested review from
Sloox,
zuziaka,
pawelpasterz,
adamfilipow92 and
piotradamczyk5
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
jan-goral
force-pushed
the
corellium-api-fixes
branch
2 times, most recently
from
fac1adc to
2dca194
Compare
|
Timestamp: 2021-05-07 15:40:33 |
jan-goral
force-pushed
the
corellium-api-fixes
branch
2 times, most recently
from
8cbdf5b to
94abd5a
Compare
* Normalize output lines from corellium console * Convert API interfaces to functional * Update adapters implementation to use SAM conversion * Rename api scope TestApk to Apk and expand interface to meet domain requirements * Fix log parser issues * Add doc for sharding structures * Add am instrument status codes constants
bootstraponline
force-pushed
the
corellium-api-fixes
branch
from
94abd5a to
ec2c88c
Compare
Sloox
approved these changes
May 7, 2021
|
|
||
| println("* Invoking devices") | ||
| val ids = api.invokeAndroidDevices(AndroidInstance.Config(2)).toMutableList() | ||
| val ids = api.invokeAndroidDevices(AndroidInstance.Config(2)).toList().toMutableList() |
There was a problem hiding this comment.
.toList().toMutableList()
Is there a reason for this?
If this is already a collection its not needed.
There was a problem hiding this comment.
Currently, it's not a Collection but a Flow, so this is blocking operation Flow.toList. I have decided to make and API functions not suspendable to take benefits from functional interfaces, so I was also forced to change some result types, and IMO Flow<String> fits much better than Deferred<List<String>>.
| clear() | ||
| } | ||
| } | ||
| Chunk(code.prefix!!, code.text.toInt(), map) | ||
| Chunk( | ||
| type = code.prefix!!, |
There was a problem hiding this comment.
double bang usually is a bad thing :(
adamfilipow92
approved these changes
May 8, 2021
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1802
This is a bunch of several minor changes cherry-picked from #1897 for splitting code review into smaller parts.
am instrumentstatus codes constantsMerging this one will make the #1897 thinner.