Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Corellium MVP CLI layer #1940

Merged
merged 1 commit into from
May 17, 2021
Merged

feat: Corellium MVP CLI layer #1940

merged 1 commit into from
May 17, 2021

Conversation

jan-goral
Copy link
Contributor

@jan-goral jan-goral commented May 17, 2021

Fixes #1939

Test Plan

How do we know the code works?

Unit test pass.

Checklist

  • Documented
  • Unit tested

@jan-goral jan-goral self-assigned this May 17, 2021
@github-actions
Copy link
Contributor

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@mergify
Copy link

mergify bot commented May 17, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@jan-goral jan-goral changed the title Add cli module feat: Add corellium cli module May 17, 2021
@jan-goral jan-goral changed the title feat: Add corellium cli module feat: Corellium MVP CLI layer May 17, 2021
@github-actions
Copy link
Contributor

Timestamp: 2021-05-17 16:57:48
Buildscan url for ubuntu-workflow run 850524959
https://gradle.com/s/meqruiahx4pbm

Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ktlint formatting is begining to look very messy :/ We should consider seeing if we can tweak it again.

@mergify mergify bot merged commit bd36a04 into master May 17, 2021
@mergify mergify bot deleted the 1939_Corellium_cli_layer branch May 17, 2021 21:28
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI layer
3 participants