Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: Refactor data scratch-Android run #1941

Merged
merged 3 commits into from
May 18, 2021

Conversation

piotradamczyk5
Copy link
Contributor

Fixes #1754

Test Plan

How do we know the code works?

  • code is refactored according to the description provided in Data scratch - android test matrix #1754 with a change
    interface Execute : (Config, Type) -> TestMatrix.Result -> interface Execute : (Config, List<Type>) -> <TestMatrix.Data>
  • all runs of flank firebase test android run ... work without any problems like previously

Checklist

  • Unit tested

@piotradamczyk5
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2021

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan: https://gradle.com/s/ezegcwhnfu7e2
Linux status failure - Build scan: https://gradle.com/s/e5xdf7nzugydq
Workflow run https://github.com/Flank/flank/actions/runs/852334967

@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2021

Timestamp: 2021-05-18 14:33:46
Buildscan url for ubuntu-workflow run 853656884

@piotradamczyk5 piotradamczyk5 force-pushed the 1754_android_run_data-refactor branch from 8a3e11d to bf4ba4c Compare May 18, 2021 07:42
@piotradamczyk5
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2021

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/ardo6njbdbxns
Linux Build scan: https://gradle.com/s/hwtemcv7pfhdy
Workflow run https://github.com/Flank/flank/actions/runs/852533077

@bootstraponline bootstraponline force-pushed the 1754_android_run_data-refactor branch from 5d1edea to 7ea360e Compare May 18, 2021 13:07
@bootstraponline bootstraponline force-pushed the 1754_android_run_data-refactor branch from 7ea360e to 2467c1d Compare May 18, 2021 13:38
Copy link
Contributor

@jan-goral jan-goral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice 👍. One thing, the stuff from ftl.gc.android is operating on com.google.testing lib so it should be in ftl.client.google package or nested, but definitely in the client layer.

@piotradamczyk5
Copy link
Contributor Author

Looks really nice 👍. One thing, the stuff from ftl.gc.android is operating on com.google.testing lib so it should be in ftl.client.google package or nested, but definitely in the client layer.

Nice catch, move to nested package because there is a little mess in ftl.client.google

@piotradamczyk5 piotradamczyk5 requested a review from jan-goral May 18, 2021 14:29
@mergify mergify bot merged commit 5a0acf2 into master May 18, 2021
@mergify mergify bot deleted the 1754_android_run_data-refactor branch May 18, 2021 15:24
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data scratch - android test matrix
4 participants