-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
refactor: Refactor data scratch-Android run #1941
Conversation
@flank-it |
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Integration tests failed ❌ |
c6fdc68
to
8a3e11d
Compare
Timestamp: 2021-05-18 14:33:46 |
8a3e11d
to
bf4ba4c
Compare
@flank-it |
Integration tests succeed for all OSes ✅ |
test_runner/src/main/kotlin/ftl/run/platform/RunAndroidTests.kt
Outdated
Show resolved
Hide resolved
5d1edea
to
7ea360e
Compare
7ea360e
to
2467c1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really nice 👍. One thing, the stuff from ftl.gc.android
is operating on com.google.testing
lib so it should be in ftl.client.google
package or nested, but definitely in the client layer.
Nice catch, move to nested package because there is a little mess in |
Fixes #1754
Test Plan
interface Execute : (Config, Type) -> TestMatrix.Result
->interface Execute : (Config, List<Type>) -> <TestMatrix.Data>
flank firebase test android run ...
work without any problems like previouslyChecklist