Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: added max-test-shards and client-details to additional-app-test-apks #1947

Merged
merged 8 commits into from
May 19, 2021
Merged

feat: added max-test-shards and client-details to additional-app-test-apks #1947

merged 8 commits into from
May 19, 2021

Conversation

asadsalman
Copy link
Contributor

@asadsalman asadsalman commented May 18, 2021 •
edited
Loading

Fixes #

This PR is a rework of #1898. A PR was merged recently which refactors some of the code I was using and introduced merge conflicts in #1898. This PR implements the same functionality with the refactored code.

This PR adds the ability to specify max-test-shards and client-details for tests under additional-app-test-apks like so:

additional-app-test-apks:
    - test: lib1-test.apk
      max-test-shards: 3
    - test: lib2-test.apk
      max-test-shards: 1
      client-details:
        modulename: lib2
        key2: val2

These configurations really improves support for multi-module projects, usually the thing I want to change the most is number of shards used to test a module. It also lets me differentiate between modules by setting key/values under client-details.

Test Plan

How do we know the code works?
Added unit tests
.

Checklist

  • Documented
  • Unit tested
  • Integration tests updated

@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@asadsalman asadsalman mentioned this pull request May 18, 2021
Closed
3 tasks
@asadsalman
Copy link
Contributor Author

recheck

@asadsalman
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@asadsalman
Copy link
Contributor Author

recheck

github-actions bot added a commit that referenced this pull request May 18, 2021
@github-actions
@asadsalman has signed the CLA from Pull Request #1947
0f36fde
@Sloox Sloox requested review from Sloox, adamfilipow92, jan-goral and pawelpasterz and removed request for Sloox and adamfilipow92 May 19, 2021 07:26
Sloox
Sloox approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

asadsalman and others added 2 commits May 19, 2021 11:15
@asadsalman @piotradamczyk5
Update test_runner/src/main/kotlin/ftl/run/platform/android/CreateAnd…
9fd6b9d 
…roidTestContext.kt

Co-authored-by: piotradamczyk5 <65554637+piotradamczyk5@users.noreply.github.com>
clean up
09aaac3
@piotradamczyk5 piotradamczyk5 self-requested a review May 19, 2021 15:33
@piotradamczyk5
Copy link
Contributor

Thank you @asadsalman for your contribution 🎉 !

@mergify mergify bot merged commit fd58169 into Flank:master May 19, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@Sloox Sloox Sloox approved these changes

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@jan-goral jan-goral Awaiting requested review from jan-goral

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

Assignees

@asadsalman asadsalman

Labels
Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asadsalman @piotradamczyk5 @Sloox