fix: Service account as default #1955

adamfilipow92 · 2021-05-21T14:38:33Z

This pr contains changes requested in #1831 and may fix #1792.

Test Plan

How do we know the code works?

Flank firstly should try to use credentials from env variable GOOGLE_APPLICATION_CREDENTIALS here
If this method fails Flank should try to load credentials from ./user_home/.flank directory here or if it's windows from %USER_HOME%/.config/gcloud/application_default_credentials.json here

github-actions · 2021-05-21T14:38:50Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions · 2021-05-21T14:44:15Z

Timestamp: 2021-05-24 08:59:54
Buildscan url for ubuntu-workflow run 870816199
https://gradle.com/s/agsrmxbx2xcya

test_runner/src/main/kotlin/ftl/client/google/Credentials.kt

adamfilipow92 requested review from piotradamczyk5 and Sloox May 21, 2021 14:39

adamfilipow92 self-assigned this May 21, 2021

bootstraponline force-pushed the 1792-1831-default-to-service-account-auth branch from 0917653 to 46b14fd Compare May 21, 2021 14:54

piotradamczyk5 reviewed May 21, 2021

View reviewed changes

test_runner/src/main/kotlin/ftl/client/google/Credentials.kt Outdated Show resolved Hide resolved

piotradamczyk5 approved these changes May 21, 2021

View reviewed changes

bootstraponline force-pushed the 1792-1831-default-to-service-account-auth branch from 3a9870f to 0d8f2e0 Compare May 21, 2021 15:56

adamfilipow92 added 2 commits May 24, 2021 08:53

Update Credentials.kt

1eb53b5

Update Credentials.kt

b8dad62

bootstraponline force-pushed the 1792-1831-default-to-service-account-auth branch from 0d8f2e0 to b8dad62 Compare May 24, 2021 08:53

Sloox approved these changes May 24, 2021

View reviewed changes

mergify bot merged commit 60dd609 into master May 24, 2021

mergify bot deleted the 1792-1831-default-to-service-account-auth branch May 24, 2021 09:06

github-actions bot locked and limited conversation to collaborators May 24, 2021