Skip to content

initialize position before InitializeComponent #3549

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Conversation

Jack251970
Copy link
Member

@Jack251970 Jack251970 commented May 16, 2025

Follow on with #3470.

Because WindowStartupLocation is Manual, so we need to initialize position before InitializeComponent.

Fix:
image

@prlabeler prlabeler bot added the bug Something isn't working label May 16, 2025
@Jack251970 Jack251970 added the Dev branch only An issue or fix for the Dev branch build label May 16, 2025
Copy link

gitstream-cm bot commented May 16, 2025

🥷 Code experts: Yusyuriv

Jack251970 has most 👩‍💻 activity in the files.
Jack251970, Yusyuriv have most 🧠 knowledge in the files.

See details

Flow.Launcher/SettingWindow.xaml.cs

Activity based on git-commit:

Jack251970
MAY 66 additions & 9 deletions
APR 56 additions & 26 deletions
MAR 9 additions & 18 deletions
FEB
JAN 14 additions & 8 deletions
DEC

Knowledge based on git-blame:
Jack251970: 53%
Yusyuriv: 28%

To learn more about /:\ gitStream - Visit our Docs

@Jack251970 Jack251970 requested a review from jjw24 May 16, 2025 11:25

This comment has been minimized.

Copy link

gitstream-cm bot commented May 16, 2025

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

@Jack251970 Jack251970 requested a review from Copilot May 16, 2025 11:25
@Jack251970 Jack251970 enabled auto-merge May 16, 2025 11:25
@Jack251970 Jack251970 removed the bug Something isn't working label May 16, 2025
@prlabeler prlabeler bot added the bug Something isn't working label May 16, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorders the initialization calls so that the window’s position is set before loading the XAML when WindowStartupLocation is Manual.

  • Moves UpdatePositionAndState() to occur before InitializeComponent()
  • Adds a clarifying comment for the new call order

Copy link
Contributor

coderabbitai bot commented May 16, 2025

📝 Walkthrough

Walkthrough

The constructor of the SettingWindow class was updated to invoke UpdatePositionAndState() before calling InitializeComponent(). This adjustment ensures the window's position and state are set before component initialization, aligning with the manual startup location configuration.

Changes

File(s) Change Summary
Flow.Launcher/SettingWindow.xaml.cs Moved the call to UpdatePositionAndState() before InitializeComponent() in the constructor and added a comment explaining the necessity due to WindowStartupLocation being Manual.

Suggested reviewers

  • onesounds

Poem

Before the window shows its face,
Its spot is set—just in case!
Update, then initialize,
A tidy order, quite wise.
A hop, a skip, a code embrace—
Settings window finds its place! 🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7e3de02 and 07ac325.

📒 Files selected for processing (1)
  • Flow.Launcher/SettingWindow.xaml.cs (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Flow.Launcher/SettingWindow.xaml.cs
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: gitStream workflow automation
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: build
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
Flow.Launcher/SettingWindow.xaml.cs (1)

30-31: Add “Ioc” to the spelling dictionary

The Ioc acronym (Inversion of Control) is being flagged by the spell checker. To suppress this warning, consider adding “Ioc” to your project’s custom dictionary or .editorconfig.

🧰 Tools
🪛 GitHub Check: Check Spelling

[warning] 31-31:
Ioc is not a recognized word. (unrecognized-spelling)

🪛 GitHub Actions: Check Spelling

[warning] 31-31: Spell check warning: Ioc is not a recognized word. (unrecognized-spelling)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e80d191 and 7e3de02.

📒 Files selected for processing (1)
  • Flow.Launcher/SettingWindow.xaml.cs (1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Check Spelling
Flow.Launcher/SettingWindow.xaml.cs

[warning] 31-31: Spell check warning: Ioc is not a recognized word. (unrecognized-spelling)

⏰ Context from checks skipped due to timeout of 90000ms (11)
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream workflow automation
  • GitHub Check: gitStream workflow automation
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: build
🔇 Additional comments (1)
Flow.Launcher/SettingWindow.xaml.cs (1)

33-35: Position initialization before component load is correct

By invoking UpdatePositionAndState() prior to InitializeComponent(), we ensure the manual WindowStartupLocation setting is respected before any UI elements are laid out. Since this method only uses window settings and system parameters (and does not depend on fully initialized visuals), it is safe to run pre-component initialization.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 22
⚠️ non-alpha-in-dictionary 13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Copy link
Contributor

@onesounds onesounds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested.

@Jack251970 Jack251970 merged commit bb25c53 into dev May 16, 2025
12 checks passed
@Jack251970 Jack251970 deleted the setting_window_position branch May 16, 2025 18:18
@jjw24 jjw24 removed bug Something isn't working 1 min review labels May 17, 2025
@jjw24 jjw24 added this to the 1.20.0 milestone May 17, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Dev branch only An issue or fix for the Dev branch build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants