Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support for ElasticSearch as a vector store #982

Merged

Conversation

vinodkiran
Copy link
Contributor

No description provided.

@HenryHengZJ
Copy link
Contributor

Were you able to get it working? @vinodkiran

@vinodkiran
Copy link
Contributor Author

@HenryHengZJ

There seems to be an issue with the underlying vector store implementation. I have raised a ticket with the langchain team.

langchain-ai/langchainjs#2857

@vinodkiran vinodkiran marked this pull request as draft October 10, 2023 06:47
@vinodkiran vinodkiran marked this pull request as ready for review October 10, 2023 14:36
@vinodkiran
Copy link
Contributor Author

@HenryHengZJ PR Is now complete...Kindly review and merge.

@HenryHengZJ
Copy link
Contributor

I have the following error:
image

@vinodkiran
Copy link
Contributor Author

I have the following error: image

Are you using the Retrieve Node? Can you add an image of the entire flow?

@vinodkiran
Copy link
Contributor Author

vinodkiran commented Oct 11, 2023

The Underlying langchain vector store creates the following index. Kindly check your index in Elastic Cloud.

{
  "mappings": {
    "dynamic_templates": [
      {
        "metadata.*": {
          "match_mapping_type": "*",
          "mapping": {
            "type": "keyword"
          }
        }
      }
    ],
    "properties": {
      "embedding": {
        "type": "dense_vector",
        "dims": 1536,
        "index": true,
        "similarity": "l2_norm",
        "index_options": {
          "type": "hnsw",
          "m": 16,
          "ef_construction": 100
        }
      },
      "metadata": {
        "properties": {
          "source": {
            "type": "keyword"
          }
        }
      },
      "text": {
        "type": "text"
      }
    }
  }
}

@HenryHengZJ
Copy link
Contributor

ah it works now:
image
image

Previously I created the index myself on ElasticSearch and that ran into error. So I specify a new index name that is not being created yet and have the underlying langchain implementation to create that index, that works.

Copy link
Contributor

@HenryHengZJ HenryHengZJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much appreciated for figuring out the issue and got it working!

@HenryHengZJ
Copy link
Contributor

HenryHengZJ commented Oct 12, 2023

@vinodkiran the metadata filter is still not working right?

we can open another PR to enhance that

@HenryHengZJ HenryHengZJ merged commit 18937de into FlowiseAI:main Oct 12, 2023
hemati pushed a commit to hemati/Flowise that referenced this pull request Dec 27, 2023
…h-vectorstore

Support for ElasticSearch as a vector store
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants