Fix another regression introduced by #1314 #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
derselbst
force-pushed
the
dsp-cpp
branch
2 times, most recently
from
ed6283d to
9e08718
Compare
derselbst
added a commit
that referenced
this pull request
Jan 25, 2025
derselbst
added a commit
that referenced
this pull request
Jan 25, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a voice is playing in delay phase, its amplitude and amplitude increment aren't updated or cleared, causing it to inherit them from a previous voice. Previously, if the increment was non-zero, nothing prevented the amplitude of the voice from rising infinitely while it was playing in delay phase.
To fix this one could either explicitly prune the amplitude to zero in this case. However, it would still attempt to read the sample buffer and multiply them with a zero amplitude, resulting in a zero sample, which is unnecessarily wasteful.
Because of that, this PR adds a new DSP routine, whose only purpose is to write silence to the dsp buffer and update the dsp phase of the voice accordingly.
Fixes #1451