Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Last explicit cast seen. #312

Merged
merged 1 commit into from
Dec 21, 2017
Merged

Last explicit cast seen. #312

merged 1 commit into from
Dec 21, 2017

Conversation

jjceresa
Copy link
Collaborator

Explicit casts to avoid narrowing conversion warnings.

Explicit casts to avoid narrowing conversion warnings.
@derselbst
Copy link
Member

I dont like it. It makes this macro magic even more complicated. But I'll take it and will probably take care of that in #197, by using unions and the same function signature for every rvoice_event_handler function. That will hopefully allow us to get rid of this huge switch case and call the functions directly.

@derselbst derselbst merged commit 5be4f31 into master Dec 21, 2017
@derselbst derselbst deleted the Explicit-cast branch December 21, 2017 13:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants