-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adding non-mutating recur for the new chain interface. #7
base: master
Are you sure you want to change the base?
Conversation
Test error looks to be something up with Zygote on master. |
I might've missed this from the |
There might have been some miscommunication on the previous apply api. I thought we wanted to separate the exported apply for chains and the internal _apply for layers. We should be able to unify though. |
That may have been my fault. My thought was to use |
I've (mostly) unified apply. There is an issue with ambiguity between the single timestep apply and the time series For the tuples (i.e. the chain.layers) specific applies we should use |
This adds the necessary implementation details for recurrent networks for the new chain api (#5). Sorry for the noise with #6 , but there was an issue with some merge conflicts that I thought I would resolve outside of the PR.
The tests indicate that this might solve some of the tests for explicit gradients. The gradient for state_0 still seems broken (returns nothing).
How this is done was adapted from Lux.jl.
PR Checklist