Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

introduce trilinear upsampling #315

Merged
merged 3 commits into from
May 4, 2021
Merged

Conversation

maxfreu
Copy link
Contributor

@maxfreu maxfreu commented Apr 19, 2021

Hi everybody!

This introduces trilinear (3D) upsampling on GPU. Maybe we can rethink the dispatch; I think the code can be deflated by smart choices.

@maxfreu maxfreu marked this pull request as draft April 19, 2021 11:56
@DhairyaLGandhi
Copy link
Member

The CUDA part of this belongs in NNlibCUDA.jl

@maxfreu
Copy link
Contributor Author

maxfreu commented Apr 20, 2021

Ööhm it should be, isn‘t it? :)

@CarloLucibello
Copy link
Member

Seems like you are based on an old commit, NNlibCUDA now is here https://github.com/FluxML/NNlibCUDA.jl

@maxfreu
Copy link
Contributor Author

maxfreu commented Apr 21, 2021

Oh I see. Why did you move it out? Now I have to make 2 forks, 2 branches, 2 PRs and the possibility of version incompatibilities arises.

@CarloLucibello
Copy link
Member

yeah, I agree, I wanted to keep it here in fact but didn't get much support #300

@maxfreu
Copy link
Contributor Author

maxfreu commented Apr 24, 2021

Just updated this PR. NNlibCUDA will follow.

@maxfreu
Copy link
Contributor Author

maxfreu commented Apr 25, 2021

For completeness I just added the CPU implementation as well. Lots of duplicate code, but works.

@CarloLucibello
Copy link
Member

this looks ready, should we merge it @maxfreu ?

@maxfreu
Copy link
Contributor Author

maxfreu commented Apr 30, 2021

You can if you want to :) FluxML/NNlibCUDA.jl#5 is also ready. Or should I squash everything into one commit first?

@maxfreu maxfreu marked this pull request as ready for review April 30, 2021 11:52
@CarloLucibello CarloLucibello merged commit 908ec40 into FluxML:master May 4, 2021
@maxfreu maxfreu deleted the trilinear branch October 23, 2021 17:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants