-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
introduce trilinear upsampling #315
Conversation
The CUDA part of this belongs in NNlibCUDA.jl |
Ööhm it should be, isn‘t it? :) |
Seems like you are based on an old commit, NNlibCUDA now is here https://github.com/FluxML/NNlibCUDA.jl |
Oh I see. Why did you move it out? Now I have to make 2 forks, 2 branches, 2 PRs and the possibility of version incompatibilities arises. |
yeah, I agree, I wanted to keep it here in fact but didn't get much support #300 |
Just updated this PR. NNlibCUDA will follow. |
For completeness I just added the CPU implementation as well. Lots of duplicate code, but works. |
this looks ready, should we merge it @maxfreu ? |
You can if you want to :) FluxML/NNlibCUDA.jl#5 is also ready. Or should I squash everything into one commit first? |
Hi everybody!
This introduces trilinear (3D) upsampling on GPU. Maybe we can rethink the dispatch; I think the code can be deflated by smart choices.