Skip to content

Simplify runtests.jl #531

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Simplify runtests.jl #531

merged 2 commits into from
Sep 11, 2023

Conversation

CarloLucibello
Copy link
Member

@CarloLucibello CarloLucibello commented Sep 9, 2023

and skip cpu tests when testing on gpu.

The diff for runtests.jl is probably difficult to understand, but basically now we have a single block of tests for each backend.

Another change is that now "AMDGPU" is part of the test environment and we don't call Pkg.develop("AMDGPU").

@ToucheSir
Copy link
Member

If this was any FluxML repo other than NNlib I'd immediately be on board, but historically we've relied on Buildkite to catch threading-related bugs in the conv kernels and elsewhere because the buildkite runners have more threads to work with. Accomodating that would be a good idea.

@ToucheSir
Copy link
Member

On a side note, should we try moving to https://github.com/JuliaTesting/ReTestItems.jl for parallel test running and possible future VS Code integration? I noticed GPUCompiler recently did.

@CarloLucibello
Copy link
Member Author

If this was any FluxML repo other than NNlib I'd immediately be on board, but historically we've relied on Buildkite to catch threading-related bugs in the conv kernels and elsewhere because the buildkite runners have more threads to work with. Accomodating that would be a good idea.

I've reinstated cpu tests on CUDA machine

@CarloLucibello CarloLucibello mentioned this pull request Sep 11, 2023
2 tasks
@CarloLucibello CarloLucibello merged commit 83df642 into master Sep 11, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants