wrap_chainrules_input for arrays of Ref #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcabbott
commented
Oct 15, 2021
| @@ -115,6 +115,7 @@ for T_outer in (:Tuple, :NamedTuple) | |||
| ChainRulesCore.backing(xp) # this is accessing ChainRulesCore internals, but it is prob safe enough, and it is fastest | |||
| end | |||
| end | |||
| @inline wrap_chainrules_output(xs::AbstractArray{<:ChainRules.Tangent}) = wrap_chainrules_output.(xs) | |||
There was a problem hiding this comment.
This could surely be made into reinterpret.
There was a problem hiding this comment.
But mostly I'd like to make things work correctly, before thinking about making them faster.
mcabbott
commented
Oct 16, 2021
oxinabox
approved these changes
Oct 16, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wants to make
wrap_chainrules_inputand friends understand arrays of mutable structs. Continuation of #1102, aims to solve JuliaDiff/ChainRules.jl#539 (comment) and assorted other problems related to ChainRules types.WIP, since thesum(f, xs)case doesn't work yet.