Fixed compile and linking problems: #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed wrong BOZ usage Fixed link usage to linkup and removed wrong external Fixed etime usage and removed wrong external Added compilerflag to allow carriagcontrol Modified scratch array initialization to match the datatype. Initialization with 0, before string -> most likely resutled in garbage (behavior unknown)
joley-gh
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few problems when compiling:
Fixed wrong BOZ usage:
At some Points the literal constant definition was defined as a suffix, which is no longer supported
-> changed ''X to Z'' for hex data
-> BOZ usage must be inside a data block, fixed aswell
Fixed link usage to linkup and removed wrong external Fixed etime usage and removed wrong external
-> 2 times the function link was used instead of linkup
-> external was used to supress the error, which is not correct
-> the same for etime, here a dummytime is added, to satisfy the parametercount of the function
Added compilerflag to allow carriagcontrol (-fdec)
Modified scratch array initialization to match the datatype.
Before, the integer array was initialized with the strings 'scra' 'tchx', which is not valid and resulted in garbage
Now it is initialized with two zeros, which solves the compiler error. The resulting behavior is unknown.
As the initialization was wrong before, the behavior should not change.