Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reorder font face urls in templates #143

Merged
merged 3 commits into from
Dec 24, 2013

Conversation

jleider
Copy link
Contributor

@jleider jleider commented Nov 8, 2013

Move svg font face to the top of the list of font face options to reduce pixelation of fonts in Chrome on Windows.

Before:
screen shot 2013-11-08 at 2 06 09 pm

After:
screen shot 2013-11-08 at 2 06 16 pm

@kaizau
Copy link
Member

kaizau commented Nov 18, 2013

Thanks for proposing this. Apparently outright reordering introduces spacing bugs in some cases. FontSpring now recommends a Chrome-only media query: http://www.fontspring.com/blog/smoother-rendering-in-chrome-update

I can make the change myself, or if you'd rather get contribution credit, I'll wait for you to PR https://github.com/FontCustom/fontcustom/tree/manifest-refactor. Thoughts?

@jleider
Copy link
Contributor Author

jleider commented Nov 18, 2013

Ah good find, I will update my pull request tomorrow.

@ghost ghost assigned kaizau Dec 19, 2013
@kaizau kaizau mentioned this pull request Dec 19, 2013
@lepture
Copy link

lepture commented Dec 19, 2013

Cool. I hope this can be merged soon.

@luccasmaso
Copy link

Nice!

@kaizau kaizau merged commit 67a5c34 into FontCustom:master Dec 24, 2013
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants