We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
There is an alignment problem in the matrix rendering when there is an empty cell.
Ex: \matrix{A & B \\ A & B \\ & B}
\matrix{A & B \\ A & B \\ & B}
It seems that the issue is located in GetTopBottomPadding:
GetTopBottomPadding
xaml-math/src/XamlMath.Shared/Atoms/MatrixAtom.cs
Lines 139 to 145 in 77d0bce
If one replace the shift argument by 0:
shift
0
Tuple<Box, Box> GetTopBottomPadding(int i, int j) { var value = matrixCellGaps[i][j].Vertical; var topBox = new StrutBox(0.0, VerticalPadding / 2 + value, 0.0, 0.0); var bottomBox = new StrutBox(0.0, VerticalPadding / 2 + value, 0.0, 0.0); return new Tuple<Box, Box>(topBox, bottomBox); }
The issue disappears:
I don't have enough hindsight to know if there are side effects.
The text was updated successfully, but these errors were encountered:
(ForNeVeR#387) Fix alignment issue in matrix with an empty cell.
18f9051
I believe that your fix is correct. I can't remember the purpose of non-zero Shift in this place either.
Shift
Sorry, something went wrong.
(ForNeVeR#387) Add a test for empty matrix cell, update tests
2cd2477
ForNeVeR
Successfully merging a pull request may close this issue.
There is an alignment problem in the matrix rendering when there is an empty cell.
Ex:
\matrix{A & B \\ A & B \\ & B}
It seems that the issue is located in
GetTopBottomPadding
:xaml-math/src/XamlMath.Shared/Atoms/MatrixAtom.cs
Lines 139 to 145 in 77d0bce
If one replace the
shift
argument by0
:The issue disappears:
I don't have enough hindsight to know if there are side effects.
The text was updated successfully, but these errors were encountered: