-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
#59 Support for Unicode delimiters. #160
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Renamed "*Element*" to "*Argument*" ("ReadElementGroup" is now named as "ReadArgumentGroup". The "ReadArgumentGroup" can now read an escape sequence of letters or a character(this is extremely useful for the "*\\left*" and "*\\right*" commands, etc). It also fixes issue ForNeVeR#158.
This comment has been minimized.
This comment has been minimized.
@B3zaleel, thanks a lot for your work! I approve this PR in principle. I've rebased it on top of today's |
ForNeVeR
requested changes
Jan 3, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ForNeVeR
requested changes
Jan 3, 2020
ForNeVeR
approved these changes
Jan 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now everything is good. Thanks for the initial implementation, @B3zaleel!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delimiter symbols that are included in a given mathematical font can now be properly rendered with the \left and \right commands. For example; \left\lbag \frac{4-x}{7x^3}\right\rbag.
TODO (Friedrich):
Closes #59.