ci: add eslint build step (#603)

.github/workflows/main.yml

@@ -48,13 +48,34 @@ jobs:
         run: |
           yarn install --force --non-interactive
 
+  eslint:
+    name: "eslint"
+    runs-on: ubuntu-latest
+    needs: install-cache
+    steps:
+      - name: Checkout Commit
+        uses: actions/checkout@v3
+      - name: Use Node.js
+        uses: actions/setup-node@v3
+      - name: Restore yarn dependencies
+        uses: actions/cache@v3
+        id: cache-dependencies
+        with:
+          path: node_modules
+          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-yarn-
+      - name: Run linter
+        run: |
+          yarn lint
+
   unit-test:
     name: "Unit Testing"
     runs-on: ubuntu-latest
     strategy:
       matrix:
         node: [18.x, 20.x, 21.x]
-    needs: install-cache
+    needs: eslint
     steps:
       - name: Checkout Commit
         uses: actions/checkout@v3

src/hooks/pagination.ts

@@ -3,7 +3,7 @@ import { useEffect, useState } from "react";
 
 export function usePagination(
   maxPages: number,
-  onComplete?: Function,
+  onComplete?: () => void,
   displayLength: number = SCREEN_DEFAULT_DISPLAY_LENGTH
 ) {
   const [page, setPage] = useState(1);

src/lib/season/routeHandler.ts

@@ -6,16 +6,14 @@ const historicalData = initializeHistoricalTempPrecip();
 const climateNormals = initializeClimateNormals();
 
 export function getSeasonData(req: Request, res: Response) {
-  const { season, ...seasonPrecipData } = historicalData.seasonPrecipData();
-
   res.json({
     season: {
       windchill: isWindchillSeason(),
       sunspot: isSunSpotSeason(),
       winter: getIsWinterSeason(),
     },
     seasonPrecip: {
-      ...seasonPrecipData,
+      ...historicalData.seasonPrecipData(),
       normal: climateNormals.getNormalPrecipForCurrentSeason()?.amount,
     },
   });

src/types/screen.types.ts

@@ -1,3 +1,3 @@
 export type AutomaticScreenProps = {
-  onComplete: Function;
+  onComplete: () => void;
 };