Skip to content

Updated to work with newer versions of RN #247

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Feb 18, 2019
Merged

Updated to work with newer versions of RN #247

merged 4 commits into from
Feb 18, 2019

Conversation

mrkpatchaa
Copy link
Contributor

Fixes #243
I've done the same described here lugg/react-native-config#248
Steps to test is already defined in #243.

  • include issue number that will be resolved by this PR (e.g. Fixes #1234)
  • include a summary of the work
  • include steps to verify
  • update tests (if applicable)
  • update readme (if applicable)
  • update typescript definitions (if applicable)

@kadikraman
Copy link
Contributor

Hi @rmkpatchaa - sorry I've just merged something that conflicts with your PR - could you change implementation to compile? This causes a warning in newer RN projects (which can be fixed with patch-package), but would break in older ones as discussed here.

@kadikraman kadikraman added this to the Next Minor Release 🎉 milestone Feb 18, 2019
@mrkpatchaa
Copy link
Contributor Author

@kadikraman it's fixed.

@kadikraman kadikraman merged commit 11581a6 into FormidableLabs:master Feb 18, 2019
@kadikraman
Copy link
Contributor

Thanks for your help! This has been published in v4.1.0.

@mrkpatchaa
Copy link
Contributor Author

👍 👍 👍
I'll do the update tomorrow ;) 💯

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

com.android.builder.internal.aapt.v2.Aapt2Exception: Android resource linking failed
2 participants