This repository was archived by the owner on Mar 18, 2023. It is now read-only.
JSON Web Keys #10
Open
JSON Web Keys #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes all key parsing and instead uses the JSON Web Key format for all further use of the keys.
FossoresLP
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 18 16 -2
Lines 734 705 -29
=====================================
- Hits 734 705 -29
Continue to review full report at Codecov.
|
This commit includes updates to the documentation comments of the JWK package to convert them to the standard go scheme. It also removes the (unused and inofficial) key type "Internal".
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds JSON Web Keys to the package, removes key parsing for other key types (like PKCS1/PKCS8) and removes the public key type that is also replaced by a JWK.
Due to the major changes in the API this is a breaking change and requires a new major release.