-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add support for Java super invocations #106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add inheritance information also for CXX files - split supertypes into superclasses and implemented interfaces -> needed for correct Java super call resolving - automatically add "this" field to dummy records as well - correctly resolve super.call() and BaseName.super.call() according to JLS 13 - unify handling of the dedicated "unknown declarations" translation unit - remove transitive closure for inheritance
…nheritance, leading to a corresponding dummy record declaration
JulianSchuette
suggested changes
Jun 18, 2020
src/main/java/de/fraunhofer/aisec/cpg/frontends/java/DeclarationHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/de/fraunhofer/aisec/cpg/passes/VariableUsageResolver.java
Outdated
Show resolved
Hide resolved
Now you broke it :D |
32e06c6
to
c2c2394
Compare
Can finally be merged, the suddenly appearing weird bug has been fixed |
oxisto
approved these changes
Jun 18, 2020
src/test/java/de/fraunhofer/aisec/cpg/enhancements/SuperCallTest.java
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed!
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #99 and finishes a task in #37 (SuperExpr support)