Make sure to move typeObservers from old to new node when replacing nodes

[oxisto]

Previously, the old node still had all the type observers, which meant that the nodes registered as observers did not get any updates. Instead, we now unregister all nodes from the old one and register them as type observers for the new node. Maybe we need to make this configurable instead of the default? We definitely need it when we replace call nodes int cast/construct expressions - but we might not need it for other cases.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.86%. Comparing base (344d366) to head (994e4eb).
Report is 1 commits behind head on main.

Additional details and impacted files

Files with missing lines	Coverage Δ
.../de/fraunhofer/aisec/cpg/helpers/SubgraphWalker.kt	81.45% <100.00%> (+0.45%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[maximiliankaul]

Looks good to me. Two points:

• the function doc explicitly states, that only EOG edges are re-wired -> might be good to include the type observers there, too.
• I cannot comment on your question in your PR description. I do not see a reason not to have them rewired but I might be missing something in the big picture.

[oxisto]

Looks good to me. Two points:

• the function doc explicitly states, that only EOG edges are re-wired -> might be good to include the type observers there, too.
• I cannot comment on your question in your PR description. I do not see a reason not to have them rewired but I might be missing something in the big picture.

Good point, I added the documentation.