Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Removing legacy resolve functions from SymbolResolver #1861

Merged
merged 19 commits into from
Jan 17, 2025

Conversation

oxisto
Copy link
Member

@oxisto oxisto commented Nov 21, 2024

This PR removes a lot of legacy functions from the symbol resolver and scope manager.

@oxisto oxisto changed the title remove more legacy code Removing legacy resolveReference function Nov 21, 2024
@oxisto oxisto added the blocked Blocked by an external factor label Nov 21, 2024
@oxisto
Copy link
Member Author

oxisto commented Nov 21, 2024

Blocked by #1862

@oxisto oxisto force-pushed the remove-more-legacy-code branch from 20cc1a7 to 9d5f539 Compare November 28, 2024 21:00
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 78.04878% with 9 lines in your changes missing coverage. Please review.

Project coverage is 77.83%. Comparing base (43bcf5f) to head (d71bba1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...raunhofer/aisec/cpg/passes/inference/PassHelper.kt 50.00% 0 Missing and 4 partials ⚠️
...n/de/fraunhofer/aisec/cpg/passes/SymbolResolver.kt 78.57% 1 Missing and 2 partials ⚠️
...ain/kotlin/de/fraunhofer/aisec/cpg/ScopeManager.kt 75.00% 1 Missing ⚠️
...hofer/aisec/cpg/frontends/cxx/ExpressionHandler.kt 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...fer/aisec/cpg/passes/TemplateCallResolverHelper.kt 80.89% <100.00%> (+0.21%) ⬆️
.../fraunhofer/aisec/cpg/frontends/cxx/CPPLanguage.kt 93.15% <100.00%> (ø)
...ofer/aisec/cpg/frontends/cxx/DeclarationHandler.kt 80.53% <100.00%> (ø)
...tlin/de/fraunhofer/aisec/cpg/passes/GoExtraPass.kt 80.16% <100.00%> (ø)
...ofer/aisec/cpg/passes/PythonAddDeclarationsPass.kt 89.06% <100.00%> (ø)
...ain/kotlin/de/fraunhofer/aisec/cpg/ScopeManager.kt 82.25% <75.00%> (-0.34%) ⬇️
...hofer/aisec/cpg/frontends/cxx/ExpressionHandler.kt 72.08% <83.33%> (+0.21%) ⬆️
...n/de/fraunhofer/aisec/cpg/passes/SymbolResolver.kt 89.36% <78.57%> (+0.12%) ⬆️
...raunhofer/aisec/cpg/passes/inference/PassHelper.kt 79.69% <50.00%> (-1.91%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxisto oxisto force-pushed the remove-more-legacy-code branch from bbcad1c to 4a5b580 Compare January 8, 2025 16:35
@oxisto oxisto changed the base branch from main to java-fix-static January 8, 2025 16:36
Base automatically changed from java-fix-static to main January 9, 2025 15:31
@oxisto oxisto changed the title Removing legacy resolveReference function Removing legacy resolve functions from SymbolResolver Jan 9, 2025
@oxisto oxisto marked this pull request as ready for review January 9, 2025 15:39
@oxisto oxisto removed the blocked Blocked by an external factor label Jan 15, 2025
@oxisto oxisto linked an issue Jan 16, 2025 that may be closed by this pull request
@oxisto oxisto enabled auto-merge (squash) January 16, 2025 19:57
@oxisto oxisto merged commit d1e18ec into main Jan 17, 2025
2 checks passed
@oxisto oxisto deleted the remove-more-legacy-code branch January 17, 2025 13:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove usage of legacy scopeManager.resolveReference function
2 participants