Cleanup SymbolResolver and make it more extensible
#2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
☔ View full report in Codecov by Sentry. |
oxisto
changed the title
SymbolResolver more extensibleSymbolResolver and make it more extensible
This was
linked to
issues
Jan 28, 2025
oxisto
force-pushed
the
make-symbol-resolver-open
branch
from
e4c4265 to
2f95012
Compare
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/passes/SymbolResolver.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/passes/SymbolResolver.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/passes/SymbolResolver.kt
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/passes/SymbolResolver.kt
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/passes/SymbolResolver.kt
Show resolved
Hide resolved
Wouldn't it then make sense to approve the PR? |
No, because it is also based on having other questions answered. |
This PR makes all the necessary handle functions `open` so that someone external to this library can extend and replace this pass, if needed. Furthermore, we make all functions we do NOT wish to be overriden `private` (mostly because we consider them part of a legacy API). Furthermore, this PR adds more documentation to this pass.
oxisto
force-pushed
the
make-symbol-resolver-open
branch
from
cf2ff65 to
971884f
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs a clean up of the
ScopeManagerespecially related to how we handle member resolution, which was still a left over from the "legacy" system.This makes all the necessary handle functions
openso that someone external to this library can extend and replace this pass, if needed. Furthermore, we make all functions we do NOT wish to be overridenprivate(mostly because we consider them part of a legacy API).Furthermore, this PR adds more documentation to this pass.