Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor firstParentOrNull to accept type parameter and optional predicate #2018

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

KuechA
Copy link
Contributor

@KuechA KuechA commented Jan 31, 2025

As discussed here: #1999 (comment)

@KuechA KuechA requested a review from fwendland as a code owner January 31, 2025 10:01
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.06%. Comparing base (eafa496) to head (f3e8962).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...kotlin/de/fraunhofer/aisec/cpg/graph/Extensions.kt 37.50% 3 Missing and 2 partials ⚠️
...ain/kotlin/de/fraunhofer/aisec/cpg/ScopeManager.kt 0.00% 0 Missing and 1 partial ⚠️
...hofer/aisec/cpg/passes/EvaluationOrderGraphPass.kt 66.66% 0 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
Files with missing lines Coverage Δ
...rc/main/kotlin/de/fraunhofer/aisec/codyze/Sarif.kt 73.07% <100.00%> (ø)
...fraunhofer/aisec/cpg/passes/inference/Inference.kt 79.02% <100.00%> (+0.27%) ⬆️
...ain/kotlin/de/fraunhofer/aisec/cpg/ScopeManager.kt 82.64% <0.00%> (+0.25%) ⬆️
...hofer/aisec/cpg/passes/EvaluationOrderGraphPass.kt 88.79% <66.66%> (+0.01%) ⬆️
...kotlin/de/fraunhofer/aisec/cpg/graph/Extensions.kt 61.68% <37.50%> (-0.85%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KuechA
Copy link
Contributor Author

KuechA commented Jan 31, 2025

Open discussion: Should we return this if it matches the predicate?

@KuechA KuechA merged commit bc4d52b into main Jan 31, 2025
3 of 4 checks passed
@KuechA KuechA deleted the ak/firstParentOrNullChange branch January 31, 2025 11:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants