Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

implementing a helper function to work with dataFlow results #2105

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

maximiliankaul
Copy link
Contributor

@KuechA can you support here? The internal variables need some re-naming (what's going on here)? And all the casting and map doesn't feel right... But it seems to work...

@KuechA
Copy link
Contributor

KuechA commented Mar 6, 2025

Thinking about it, maybe we can re-use some stuff which we have for the sarif-printing.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 59.57447% with 19 lines in your changes missing coverage. Please review.

Project coverage is 78.44%. Comparing base (a771536) to head (ff1ed0a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...kotlin/de/fraunhofer/aisec/cpg/graph/Extensions.kt 55.00% 8 Missing and 1 partial ⚠️
.../kotlin/de/fraunhofer/aisec/cpg/query/QueryTree.kt 57.14% 6 Missing ⚠️
...otlin/de/fraunhofer/aisec/cpg/query/FlowQueries.kt 69.23% 3 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (59.57%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
Files with missing lines Coverage Δ
...rc/main/kotlin/de/fraunhofer/aisec/codyze/Sarif.kt 73.07% <ø> (ø)
...otlin/de/fraunhofer/aisec/cpg/query/FlowQueries.kt 93.49% <69.23%> (-2.22%) ⬇️
.../kotlin/de/fraunhofer/aisec/cpg/query/QueryTree.kt 59.43% <57.14%> (-0.35%) ⬇️
...kotlin/de/fraunhofer/aisec/cpg/graph/Extensions.kt 55.65% <55.00%> (-0.32%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oxisto oxisto linked an issue Mar 7, 2025 that may be closed by this pull request
@maximiliankaul
Copy link
Contributor Author

Remove the successfulLastNodes function and the companion object in #2100 once this is ready.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve QueryTree output for usage in SARIF
2 participants