Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: Serialize CAN frames when DLC is not set #681

Merged
merged 2 commits into from
Feb 17, 2025
Merged

fix: Serialize CAN frames when DLC is not set #681

merged 2 commits into from
Feb 17, 2025

Conversation

rumpelsepp
Copy link
Member

  • fix: Serialize CAN frame even if dlc is not set
  • tests: Add tests for serializing CAN frames

@rumpelsepp rumpelsepp requested a review from peckto as a code owner February 4, 2025 15:56
@rumpelsepp rumpelsepp changed the title can2 fix: Serialize CAN frames when DLC is not set Feb 4, 2025
@rumpelsepp rumpelsepp added the bug Something isn't working label Feb 4, 2025
@rumpelsepp rumpelsepp mentioned this pull request Feb 4, 2025
Closed
@ferdinandjarisch ferdinandjarisch self-requested a review February 14, 2025 12:46
ferdinandjarisch
ferdinandjarisch approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@ferdinandjarisch ferdinandjarisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixes the bug!

@rumpelsepp rumpelsepp merged commit 6443848 into master Feb 17, 2025
28 checks passed
@rumpelsepp rumpelsepp deleted the can2 branch February 17, 2025 08:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ferdinandjarisch ferdinandjarisch ferdinandjarisch approved these changes

@peckto peckto Awaiting requested review from peckto peckto is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rumpelsepp @ferdinandjarisch