pass sourcemap option to plugins

FredKSchott · Jul 30, 2019 · 10b386b · 10b386b
1 parent 6cac027
commit 10b386b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 15 deletions.
diff --git a/package.json b/package.json
@@ -34,13 +34,6 @@
           "minNodeVersion": 8
         }
       ],
-      [
-        "@pika/plugin-simple-bin",
-        {
-          "bin": "pack",
-          "minNodeVersion": 8
-        }
-      ]
     ]
   },
   "publishConfig": {

diff --git a/src/commands/build.ts b/src/commands/build.ts
@@ -15,7 +15,6 @@ type Flags = {
   force?: boolean;
 };
 
-
 export function hasWrapper(commander: Object, args: Array<string>): boolean {
   return true;
 }
@@ -51,6 +50,7 @@ export class Build {
     const outPretty = path.relative(cwd, out) + path.sep;
 
     const manifest = await config.manifest;
+    const {sourcemap} = manifest['@pika/pack'] || {sourcemap: false};
     const distRunners = await config.getDistributions();
     const builderConfig: Partial<BuilderOptions> = {
       out,
@@ -92,7 +92,7 @@ export class Build {
         if (runner.validate) {
           const result = await runner.validate({
             ...builderConfig,
-            options,
+            options: {sourcemap, ...options},
           });
           if (result instanceof Error) {
             throw result;
@@ -109,7 +109,7 @@ export class Build {
         await (runner.beforeBuild &&
           runner.beforeBuild({
             ...builderConfig,
-            options,
+            options: {sourcemap, ...options},
           }));
       }
     });
@@ -132,17 +132,17 @@ export class Build {
           await (runner.beforeJob &&
             runner.beforeJob({
               ...builderConfig,
-              options,
+              options: {sourcemap, ...options},
             }));
           await (runner.build &&
             runner.build({
               ...builderConfig,
-              options,
+              options: {sourcemap, ...options},
             }));
           await (runner.afterJob &&
             runner.afterJob({
               ...builderConfig,
-              options,
+              options: {sourcemap, ...options},
             }));
         } catch (err) {
           if (flags.force) {
@@ -172,7 +172,7 @@ export class Build {
         await (runner.afterBuild &&
           runner.afterBuild({
             ...builderConfig,
-            options,
+            options: {sourcemap, ...options},
           }));
       }
 

diff --git a/src/index.ts b/src/index.ts
@@ -44,7 +44,6 @@ function findProjectRoot(base: string): string {
   return base;
 }
 
-
 export async function cli(args: string[]) {
   const version = getVersion();
   loudRejection();