This repository was archived by the owner on Apr 21, 2022. It is now read-only.
Skip prereq check if windows #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes!!! Thanks for tracking this down, I can't believe something as stable/foundational as npm just has a blanket issue with child_process. 🤷♂️ Will merge and then run format on my end. Thanks again for the fix! |
This was referenced Mar 24, 2019
1 task
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for #37 & #2
After playing around it, i determined its a straight up issue with child.process.exec and npm on windows default shell. Therefore this quick fix just completely skips prereq checks if windows, and will rely on publish.ts to report access errors if publishing fails.
I successfully published pikaaccesstest