Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make full screen in the same monitor where the connection window reside #1084

Merged
merged 3 commits into from
Jan 9, 2017

Conversation

antenore
Copy link
Member

@antenore antenore commented Jan 6, 2017

This should fix #124 if GTK version => 3.18

Please tests and let me know.

@antenore
Copy link
Member Author

antenore commented Jan 9, 2017

No issues so far, and it seems to work properly, can I merge into 'next'?

@giox069
Copy link
Contributor

giox069 commented Jan 9, 2017

+1

@antenore antenore merged commit 94fd079 into next Jan 9, 2017
@antenore antenore deleted the issue_124-fullscreen branch February 1, 2017 23:09
@mvdw
Copy link

mvdw commented Feb 2, 2017

"Make full screen in the same monitor where the connection window reside"
In some cases, that is the expected behavior, but it is a bad idea in the case where I go from not-full-screen to full-screen.
Please reconsider.
PS: Do you need to choose a monitor in Remmina? I thought the environment has algorithms implemented for that.

@antenore
Copy link
Member Author

antenore commented Feb 2, 2017

@mvdw Thanks for your comment, can you please tell me about your specific issue?
Thanks in advance

@mvdw
Copy link

mvdw commented Feb 2, 2017

No problem. I understand there are many situations. BTW, thanks for the work on Remmina!

I have a laptop at the left with external monitor to the right, openSuse 42.2 KDE plasma5, Remmina 1.2.0 rcgit.13.
If I have a rdp connection with Remmina open, not full screen - completely on the external monitor.
Then I toggle Remmina to full screen mode (with the Remmina button).
What happens next, is that the full screen opens either on the laptop screen, or on the external monitor, depending on the connection window location:

  1. Connection window not open - the full screen opens on the laptop (left) - unexpected.
  2. Connection window at the laptop screen - the full screen opens on the laptop (left) - unexpected.
  3. Connection window open at the right monitor: the full screen opens on the right - expected.

@antenore
Copy link
Member Author

antenore commented Feb 3, 2017

Yep, that's a good point.
I think the best is to let the user choose adding an option in the Remmina preferences. Thought it won't be anyway that much flexible as well, but I don't see how it can be done better.

Do you mind to cut and paste this in a new issue? Thanks in advance.
I hope that I'll have time ASAP.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants