Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Profile and group name niddles in the pre/post commands #1492

Merged
merged 2 commits into from
Feb 27, 2018

Conversation

antenore
Copy link
Member

This patch improve the pre and post commands adding the profile and group name as an additional niddle.

@antenore
Copy link
Member Author

#1485 @AlexGluck please test if possible

@AlexGluck
Copy link

AlexGluck commented Feb 27, 2018

How i can build package with this feature and install in fedora 27?

@antenore
Copy link
Member Author

I'm going to merge it and than I'll give you the procedure to install it from the main branch.

Do you mean Fedora27?

@antenore antenore merged commit d30b666 into next Feb 27, 2018
@antenore antenore self-assigned this Feb 27, 2018
@AlexGluck
Copy link

yep, sorry

@antenore
Copy link
Member Author

antenore commented Feb 27, 2018

Remove any remmina and freerdp package you have and than follow this

https://github.com/FreeRDP/Remmina/wiki/Compile-on-Fedora-20-~-26

Normally just copy&paste from that should work. If you have any issues come back to me

@AlexGluck
Copy link

Step 2 doesn't work.
I write this batch:
rpm -qa | grep remmina | cut -f1 -d '1' | rev | cut -f2- -d '-' | rev | while read i; do sudo dnf remove $i; done

@AlexGluck
Copy link

Doesn.t work

[alexgluck@gluck-laptop ~]$ ls -la ~/remmina.sh 
-rwxr-x---. 1 alexgluck alexgluck 45 фев 27 22:28 /home/alexgluck/remmina.sh
** (remmina:22070): WARNING **: Command ~/remmina.sh host1 group1 exited with error: Не удалось выполнить процесс-потомок «~/remmina.sh» (no such file or directory)
** (remmina:22070): WARNING **: Command /home/alexgluck/remmina.sh host1 group1 exited with error: Не удалось выполнить процесс-потомок «/home/alexgluck/remmina.sh» (Нет такого файла или каталога)

2018-02-27 22-37-08

@antenore
Copy link
Member Author

antenore commented Feb 27, 2018

I think you didn't close Remmina after the upgrade. Can you execute the following?

pkill remmina && remmina --version

@AlexGluck
Copy link

pill i cant find

StatusNotifier/Appindicator support: not supported by desktop. libappindicator will try to fallback to GtkStatusIcon/xembed
Running under Gnome Shell version 3.26.2
Remmina - 1.2.0-rcgit-27 (git 6bcd907c)

@AlexGluck
Copy link

[alexgluck@gluck-laptop Remmina]$ pkill remmina ;remmina --version
StatusNotifier/Appindicator support: not supported by desktop. libappindicator will try to fallback to GtkStatusIcon/xembed
Running under Gnome Shell version 3.26.2
Remmina - 1.2.0-rcgit-27 (git 6bcd907c)

@AlexGluck
Copy link

in fedora repo remmina version 1.2.0-0.45.20180107.git.d70108c.fc27

@antenore
Copy link
Member Author

I saw now the problem, you must write the full path to remmina.sh and not with ~

@AlexGluck
Copy link

AlexGluck commented Feb 27, 2018

Above I have already written that I tried full path. #1492 (comment)

@AlexGluck
Copy link

I'm stupid. Misspelling path after shebang:

[alexgluck@gluck-laptop Remmina]$ cat ~/remmina.sh 
#!/usr/binenv bash
echo "$@" >> ~/remmin.log

But error output wrong too.

@AlexGluck
Copy link

Thanks for you help. May be in russian error, sound poor. But basic feature is cool and work properly. I will wait while this feature added in official fedora repos.

@antenore
Copy link
Member Author

Spasibo.

If you need more support let me know. May be you can open an issue to the fedora team to update remmina?

Poka.

@antenore
Copy link
Member Author

For the error message you see in Russian we can do almost nothing has it's bash that trow out that error.

@antenore
Copy link
Member Author

I'm closing this as for me it's solved upstream.

@AlexGluck
Copy link

Ticket in Fedora for update.

@scaronni
Copy link

@AlexGluck new build in updates testing, please test and provide feedback.

@antenore
Copy link
Member Author

@scaronni I was in contact with @Hubbitus to update the Fedora packages.

It's great! More over on the last commit, it's just perfect!!!

Do you think is it possible to automatize those builds, at least, at each new official release?

  • eventually having some rights to request a testing build against the last commit?

If you prefer we can speak about this privately.

BTW, have I said THANK YOU! ??? :-)

@antenore antenore deleted the 1485_profenhance branch March 23, 2018 20:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants