Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

stats: detect flatpak sandbox at runtime #1541

Merged
merged 1 commit into from
Mar 29, 2018
Merged

stats: detect flatpak sandbox at runtime #1541

merged 1 commit into from
Mar 29, 2018

Conversation

larchunix
Copy link
Contributor

As discussed in fa6df20.

@giox069 what do you think about it?

@larchunix larchunix requested a review from giox069 March 28, 2018 21:22
@giox069
Copy link
Contributor

giox069 commented Mar 29, 2018

+1 for the changes in remmina/src/remmina_stats.c to detect flatpack sandbox at runtime (I can't test it, I hope it will work :) :))
I'm not sure to remove -DFLATPAK_BUILD from cmakefiles and .json: it could be useful in the future. @antenore and @larchunix , what do you think to keep it?

@antenore
Copy link
Member

IMHO if we don't need it now better to temove

@giox069 giox069 merged commit 6b0fc75 into FreeRDP:next Mar 29, 2018
@giox069
Copy link
Contributor

giox069 commented Mar 29, 2018

Thank you @larchunix.

@larchunix larchunix deleted the flatpak_stats branch March 29, 2018 21:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants