Switch back to x11 GTK backend under Wayland #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that GTK Clipboard handling under wayland backend is quite broken: 1) owner-change signal is emitted when the window take focus or is moved, not when clipboard owner changes 2) The signal owner-change event data GdkEventOwnerChange has the "owner" field set to NULL, even when the new owner is local to the application 3) the clipboard owner of a GtkClipboard object is only set when we call gtk_clipboard_set_with_owner(), and is not set when another process takes clipboard ownership. 4) Calling gtk_clipboard_set_with_owner() emits owner-change signal two times. All those problems disappear under XWayland. Currently testing on Ubuntu 17.10 GTK 3.33.25. Since there are no know workaround in GTK for Remmina to know: 1) When an external process has taken clipboard ownership 2) Know if the current clipboard owner is Remmia or not we switch back to XWayland.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that GTK Clipboard handling under wayland backend is quite broken:
not when clipboard owner changes
field set to NULL, even when the new owner is local to the application
when we call gtk_clipboard_set_with_owner(), and is not set
when another process takes clipboard ownership.
two times.
All those problems disappear under XWayland.
Currently testing on Ubuntu 17.10 GTK 3.33.25.
Since there are no know workaround in GTK for Remmina to know:
we switch back to XWayland.