Update Flatpak to GNOME SDK 3.28 #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport patch for libappindicator in order to fix a FTBFS issue. See: https://bugs.launchpad.net/ubuntu/+source/libappindicator/+bug/1757121
|
It builds successfully. I wish we could run some automatic tests on some building server, instead of testing manually. |
|
Sorry I have trouble downloading some sources in my network (so my test relies on cloud building 😂 ). Anyone else testing? #1573 |
|
I'm testing, but looks good to me. |
antenore
approved these changes
Apr 16, 2018
|
That's good 😀 In case of any problem I suggest a rollback then. The newer the better eh? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@antenore and/or @amtlib-dot-dll, could you build and test this ? If everything is fine you can also update flathub manifest.