Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add portMEMORY_BARRIER defination for Xtensa platform #1116

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

superroc
Copy link
Contributor

Add portMEMORY_BARRIER defination for Xtensa platform.

Description

The following code in xTaskResumeAll function may be over-optimized, the result is that the variable pxTCB does not change after the first loop.

pxTCB = listGET_OWNER_OF_HEAD_ENTRY( ( &xPendingReadyList ) );
listREMOVE_ITEM( &( pxTCB->xEventListItem ) );
portMEMORY_BARRIER();
listREMOVE_ITEM( &( pxTCB->xStateListItem ) );
prvAddTaskToReadyList( pxTCB );

The problem will be solved after define portMEMORY_BARRIER with a proper statement.

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

#1114

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@superroc superroc requested a review from a team as a code owner August 12, 2024 10:21
Copy link

@aggarg aggarg merged commit 190906a into FreeRTOS:main Aug 12, 2024
16 checks passed
@superroc superroc deleted the hifi3z branch August 13, 2024 08:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants