Skip to content

Fix compilation issue of IA32_flat port #1122

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

kar-rahul-aws
Copy link
Member

@kar-rahul-aws kar-rahul-aws commented Aug 16, 2024

Description

This PR fixes the code formatting in ISR_Support.h file in the GCC\IA32_flat port, without this fix the current assembly code fails to build succesfully.

Test Steps

gcc -m32 -march=pentium -c -o portASM.o portable/GCC/IA32_flat/portASM.S -Iexamples/template_configuration -DconfigUSE_COMMON_INTERRUPT_ENTRY_POINT=1 -DconfigSUPPORT_FPU=0

Before applying the patch

portable/GCC/IA32_flat/portASM.S: Assembler messages:
portable/GCC/IA32_flat/portASM.S:231: Error: unknown pseudo-op: `.'
portable/GCC/IA32_flat/portASM.S:231: Error: no such instruction: `if 0==1'
portable/GCC/IA32_flat/portASM.S:231: Error: invalid character '(' in mnemonic
portable/GCC/IA32_flat/portASM.S:254: Error: junk `movl( % eax)' after register
portable/GCC/IA32_flat/portASM.S:254: Error: unknown pseudo-op: `.'
portable/GCC/IA32_flat/portASM.S:254: Error: no such instruction: `if 0==1'
portable/GCC/IA32_flat/portASM.S:254: Error: invalid character '(' in mnemonic
portable/GCC/IA32_flat/portASM.S:254: Error: ".endif" without ".if"
portable/GCC/IA32_flat/portASM.S:258: Error: ".endif" without ".if"

After applying the patch, the code compiles successfully and portasm.o is generated.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

#1121

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kar-rahul-aws kar-rahul-aws requested a review from a team as a code owner August 16, 2024 13:43
@kar-rahul-aws kar-rahul-aws changed the title Fix compilation issue of IAR32 port Fix compilation issue of IAR32_flat port Aug 16, 2024
@kar-rahul-aws kar-rahul-aws changed the title Fix compilation issue of IAR32_flat port Fix compilation issue of IA32_flat port Aug 16, 2024
@Ryzee119
Copy link
Contributor

@kar-rahul-aws thank you for the quick fix. I can confirm that this fixes the issue.

Copy link

@kar-rahul-aws kar-rahul-aws merged commit 49e8831 into FreeRTOS:main Aug 19, 2024
16 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants