-
Notifications
You must be signed in to change notification settings - Fork 180
Improve Validation of Config #1084
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
@HTRamsey Thanks for the PR. Would you mind running uncrustify on your changes? |
/bot run formatting |
#if ( configSUPPORT_DYNAMIC_ALLOCATION == 0 ) | ||
#error configSUPPORT_DYNAMIC_ALLOCATION must be set to 1 | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is good. We can remove this once #449 has been resolved.
@tony-josi-aws we can change the static assert definition, that semi colon is just to allow multiple asserts on the same line. Have to change unsigned comparisons against 0 too |
78779c4
@HTRamsey, makes sense to remove the semicolon if we are not using multiple asserts on the same line. And MISRA doesn't like literals without a sign (U) explicitly specified. |
1f91f80
to
a444ee6
Compare
@tony-josi-aws Should I add literal signs to all of the default configs? |
@HTRamsey, not all, but those that are compared/used/assigned to unsigned variables. The latest main branch is validated with coverity for MISRA 2012, so unless new macros are being added, the existing default macro definitions should be good. |
Is there an actual minimum kernel version that is supported? |
FreeRTOS+TCP requires kernel version that supports event groups, which is added with kernel version v8.1. |
Improve Validation of Config
Description
Verifies FreeRTOSConfig.h values that are required
Uses static asserts on a few ipconfig values that can't be compile time checked normally
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.